[Intl] Made countries ISO 3166 compliant + exclude Zzzz script code #31365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
commented
May 2, 2019
| self::EUROZONE_ID => true, | ||
| self::UNITED_NATIONS_ID => true, | ||
| // No longer exists | ||
| self::NETHERLANDS_ANTILLES_ID => true, |
This was referenced May 2, 2019
Merged
|
See #31350 (comment) it seems there are a few more codes that should be excluded before we comply with ISO-3166 |
fabpot
added a commit
that referenced
this pull request
May 7, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Intl] Cleanup | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> cleanup of #31365 for 3.4 + some other stuff to keep in sync across branches Commits ------- 70a941e [Intl] Cleanup
|
@ro0NL Can you rebase this one please? |
|
@fabpot done. |
fabpot
approved these changes
May 7, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
May 7, 2019
…z script code (ro0NL) This PR was merged into the 4.3-dev branch. Discussion ---------- [Intl] Made countries ISO 3166 compliant + exclude Zzzz script code | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes (including intl-data group) | Fixed tickets | #31350 (comment), #18613 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> For consistency :) Commits ------- 1bb7dde [Intl] Made countries ISO 3166 compliant + exclude Zzzz script code
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency :)