Skip to content

[Console] Fix auto-complete for ChoiceQuestion (multi-select answers) #31377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2019

Conversation

battye
Copy link
Contributor

@battye battye commented May 3, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24072
License MIT
Doc PR -

Previously, a bug existed whereby for multi-select questions, the auto-complete would only work for the first answer supplied by the user. On all subsequent answers, the auto-complete would not appear.

Now it works as expected:

screenshot

@battye battye force-pushed the bugfix/autocomplete-choice branch 3 times, most recently from df84a50 to 0a762e2 Compare May 4, 2019 03:42
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone May 5, 2019
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍 with minor comment

@fabpot
Copy link
Member

fabpot commented May 6, 2019

Thank you @battye.

@fabpot fabpot force-pushed the bugfix/autocomplete-choice branch from 519be66 to 59321fe Compare May 6, 2019 09:25
@fabpot fabpot merged commit 59321fe into symfony:3.4 May 6, 2019
fabpot added a commit that referenced this pull request May 6, 2019
…ct answers) (battye)

This PR was squashed before being merged into the 3.4 branch (closes #31377).

Discussion
----------

[Console] Fix auto-complete for ChoiceQuestion (multi-select answers)

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24072
| License       | MIT
| Doc PR        | -

Previously, a bug existed whereby for multi-select questions, the auto-complete would only work for the first answer supplied by the user. On all subsequent answers, the auto-complete would not appear.

Now it works as expected:

![screenshot](https://user-images.githubusercontent.com/2110222/57158657-8c147e80-6e16-11e9-94f7-a9bc95506545.png)

Commits
-------

59321fe [Console] Fix auto-complete for ChoiceQuestion (multi-select answers)
This was referenced May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants