[Messenger] Making cache rebuild correctly when message subscribers change #31445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Config/Resource/ReflectionClassResource.php
Outdated
Show resolved
Hide resolved
2355715 to
d88446b
Compare
weaverryan
commented
May 9, 2019
| class TestMessageSubscriberConfigHolder | ||
| { | ||
| public static $handledMessages = []; | ||
| } |
There was a problem hiding this comment.
I discovered that testEventSubscriber() and testServiceSubscriber() are invalid. Part of the signature of ReflectionClassResource is the constants and their values. So, to purely test that the resource becomes stale when a static method is called, we must do that without modifying any constants.
Those other 2 methods need to be fixed in 3.4 - you can comment out the code in ReflectionClassResource for each and they still pass.
nicolas-grekas
approved these changes
May 11, 2019
|
Good catch, thanks @weaverryan. |
nicolas-grekas
added a commit
that referenced
this pull request
May 11, 2019
…bscribers change (weaverryan) This PR was merged into the 4.2 branch. Discussion ---------- [Messenger] Making cache rebuild correctly when message subscribers change | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31409 | License | MIT | Doc PR | not needed An edge-case that's identical to `EventSubscriberInterface`: when the return value of `getHandledMessages()` changes, the container needs to be rebuilt. If you're wondering why these checks aren't in their own resource class, see #25984 - it's something we probably should do, but haven't done yet. Commits ------- d88446b Making cache rebuild correctly with MessageSubscriberInterface return values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An edge-case that's identical to
EventSubscriberInterface: when the return value ofgetHandledMessages()changes, the container needs to be rebuilt.If you're wondering why these checks aren't in their own resource class, see #25984 - it's something we probably should do, but haven't done yet.