[Validator] add Validation::createCallable() #31466

janvernieuwe · 2019-05-10T11:33:04Z

Q	A
Branch?	4.4
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

This is an initial PR to check/discuss the implementation of a callable validator.
If there is interest in merging this, I will gladly update the docs and such.

The use case is mainly for validation of console questions, since the default validation has been removed in the latest version and i could not find an easy solution to replace it (if there already is some solution for this, i'm not aware of it) and the question helper uses callables.
This small class allows the standard symfony validators to be used in console questions, or any other location that requires a callable validator.

Example use case:

$io = new SymfonyStyle($input, $output);
$required = new CallableValidator([new NotBlank()]);
$wsdl = $io->ask('Wsdl location (URL or path to file)', null, $required);

As said before, this is by no means the final version, but I would like to know if there is interest in merging this (and receive some feedback about the implementation) before I put any more effort into this.

Simperfit

You should remove the two unrelated commits

janvernieuwe · 2019-05-13T07:32:56Z

Updated it, guess my fork got out of sync

ro0NL · 2019-06-04T09:35:03Z

instead of a new CallableValidator, which isn't really a validator from the component pov (as it's not a true ValidatorInterface implementation) ... what about Validation::createCallable($constraints): Closure

janvernieuwe · 2019-06-07T12:43:34Z

@ro0NL that can work too, it should be pretty easy as something like this in the Validation class:

    public static function createCallable(Constraint...$constraints): callable
    {
        $validator = self::createValidator();

        return static function ($value) use ($constraints, $validator) {
            $violations = $validator->validate($value, $constraints);
            if (0 !== $violations->count()) {
                throw new LogicException((string)$violations);
            }

            return $value;
        };
    }

Don't know if it is desirable to create a new Validator instance for each new callable though, but it shouldn't be too bad.

janvernieuwe · 2019-07-26T08:33:04Z

Failures on travis don't seem to be related to any of my code changes as far as i can see...

src/Symfony/Component/Validator/Validation.php

nicolas-grekas · 2019-11-05T15:57:39Z

src/Symfony/Component/Validator/Validation.php

+        return static function ($value) use ($constraints, $validator) {
+            $violations = $validator->validate($value, $constraints);
+            if (0 !== $violations->count()) {
+                throw new LogicException((string) $violations);


This should be a RuntimeException to me, or better: a class derived from RuntimeException modelled after ValidationFailedException from the Messenger component. WDYTN

Added a new exception for this, let me know if you want to change the naming or anything.

ro0NL

nice feature 👍

nicolas-grekas · 2020-01-21T21:59:20Z

can you please rebase+retarget for master?
if not no worries, we can do it on merger's side.

janvernieuwe · 2020-01-22T08:20:55Z

I won't immediately have time for retargetting. So if it can be done on the merger's side, that'd be great!

nicolas-grekas

(I rebased the PR for master)

fabpot · 2020-02-04T13:38:36Z

Thank you @janvernieuwe.

…euwe) This PR was merged into the 5.1-dev branch. Discussion ---------- [Validator] add Validation::createCallable() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This is an initial PR to check/discuss the implementation of a callable validator. If there is interest in merging this, I will gladly update the docs and such. The use case is mainly for validation of console questions, since the default validation has been removed in the latest version and i could not find an easy solution to replace it (if there already is some solution for this, i'm not aware of it) and the question helper uses callables. This small class allows the standard symfony validators to be used in console questions, or any other location that requires a callable validator. Example use case: ```php $io = new SymfonyStyle($input, $output); $required = new CallableValidator([new NotBlank()]); $wsdl = $io->ask('Wsdl location (URL or path to file)', null, $required); ``` As said before, this is by no means the final version, but I would like to know if there is interest in merging this (and receive some feedback about the implementation) before I put any more effort into this. Commits ------- 2e4f2ac [Validator] add Validation::createCallable()

stof · 2020-05-18T09:14:46Z

I see an issue here: the callable creation always creates a new Validator object instead of allowing to use an existing one. This makes it incompatible with the DI integration, and so forbids using any constraint validator which has some dependency.
And it also makes it incompatible with any mapping configuration.

nicolas-grekas · 2020-05-18T09:57:11Z

@stof good catch. What's your reco here? Revert? Improving? (in this case, could you work on a PR?)

stof · 2020-05-18T10:35:32Z

Well, the variadic signature makes it hard to improve, as we cannot add an optional parameter to pass a validator instance.

stof · 2020-05-18T10:37:00Z

My proposal: change the constraints from a variadic argument to an array argument (or maybe ConstraintInterface[]|ConstraintInterface for the case of only one constraint), and add the validator as an optional second argument.

stof · 2020-05-18T10:37:53Z

Btw, this is the main reason why I don't like variadic arguments: they lock the signature entirely.

@stof

…eCallable() (nicolas-grekas) This PR was merged into the 5.1 branch. Discussion ---------- [Validator] allow passing a validator to Validation::createCallable() | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As spotted by @stof in #31466 (comment) Commits ------- 1357cbf [Validator] allow passing a validator to Validation::createCallable()

@stof

…eCallable() (nicolas-grekas) This PR was merged into the 5.1 branch. Discussion ---------- [Validator] allow passing a validator to Validation::createCallable() | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As spotted by @stof in symfony/symfony#31466 (comment) Commits ------- 1357cbf8ed [Validator] allow passing a validator to Validation::createCallable()

This PR was merged into the 5.1 branch. Discussion ---------- Fix tests namespaces | Q | A | ------------- | --- | Branch? | 5.1  | Bug fix? | no | New feature? | no  | Deprecations? | no  | Tickets | N/A  | License | MIT | Doc PR | N/A Fixes namespaces for tests introduced in #34869 & #31466, spotted by travis generating Composer warnings: ``` Deprecation Notice: Class Symfony\Component\Console\Tests\Output\NullOutputFormatterStyleTest located in ./src/Symfony/Component/Console/Tests/Formatter/NullOutputFormatterStyleTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///home/travis/.phpenv/versions/7.4.9/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201 Deprecation Notice: Class Symfony\Component\Console\Tests\Output\NullOutputFormatterTest located in ./src/Symfony/Component/Console/Tests/Formatter/NullOutputFormatterTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///home/travis/.phpenv/versions/7.4.9/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201 Deprecation Notice: Class Symfony\Component\Validator\Tests\Validator\ValidationTest located in ./src/Symfony/Component/Validator/Tests/ValidationTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///home/travis/.phpenv/versions/7.4.9/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201 ``` Commits ------- 4e68c90 Fix tests namespaces

carsonbot added Status: Needs Review Feature labels May 10, 2019

nicolas-grekas added this to the next milestone May 11, 2019

Simperfit suggested changes May 12, 2019

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels May 12, 2019

janvernieuwe requested review from dunglas, lyrixx and sroze as code owners May 13, 2019 07:17

carsonbot added Status: Needs Review and removed Status: Needs Work labels May 13, 2019

janvernieuwe force-pushed the callable-validator branch 2 times, most recently from 1edd0a0 to 94d121f Compare May 13, 2019 07:31

janvernieuwe changed the base branch from master to 4.3 May 13, 2019 07:31

lyrixx changed the title ~~Callable validator~~ [Console] Callable validator Jun 4, 2019

lyrixx changed the base branch from 4.3 to 4.4 June 4, 2019 12:08

janvernieuwe force-pushed the callable-validator branch 3 times, most recently from 6fe4e80 to 015b0c8 Compare July 26, 2019 08:18

nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019

nicolas-grekas changed the title ~~[Console] Callable validator~~ [Validator] add Validation::createCallable() Nov 5, 2019

nicolas-grekas reviewed Nov 5, 2019

View reviewed changes

nicolas-grekas modified the milestones: 4.4, next Nov 8, 2019

ro0NL approved these changes Jan 21, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Jan 21, 2020

xabbuh added the Validator label Jan 24, 2020

[Validator] add Validation::createCallable()

2e4f2ac

nicolas-grekas changed the base branch from 4.4 to master January 27, 2020 21:35

nicolas-grekas force-pushed the callable-validator branch from a77379c to 2e4f2ac Compare January 27, 2020 21:35

nicolas-grekas approved these changes Jan 27, 2020

View reviewed changes

fabpot approved these changes Feb 4, 2020

View reviewed changes

fabpot mentioned this pull request Feb 4, 2020

[Validator] add Validation::createCallable() symfony/symfony-docs#13045

Closed

fabpot merged commit 2e4f2ac into symfony:master Feb 4, 2020

nicolas-grekas modified the milestones: next, 5.1 May 4, 2020

fabpot mentioned this pull request May 5, 2020

Release v5.1.0-BETA1 #36713

Merged

nicolas-grekas mentioned this pull request May 18, 2020

[Validator] allow passing a validator to Validation::createCallable() #36859

Merged

ro0NL mentioned this pull request May 19, 2020

[RFC][OptionsResolver] Constraints #36820

Closed

ogizanagi mentioned this pull request Aug 17, 2020

Fix tests namespaces #37858

Merged

janvernieuwe deleted the callable-validator branch January 15, 2021 00:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Validator] add Validation::createCallable() #31466

[Validator] add Validation::createCallable() #31466

janvernieuwe commented May 10, 2019 •

edited by lyrixx

Loading

Simperfit left a comment

janvernieuwe commented May 13, 2019

ro0NL commented Jun 4, 2019

janvernieuwe commented Jun 7, 2019 •

edited

Loading

janvernieuwe commented Jul 26, 2019

nicolas-grekas Nov 5, 2019

janvernieuwe Nov 29, 2019

ro0NL left a comment

nicolas-grekas commented Jan 21, 2020

janvernieuwe commented Jan 22, 2020

nicolas-grekas left a comment

fabpot commented Feb 4, 2020

stof commented May 18, 2020

nicolas-grekas commented May 18, 2020

stof commented May 18, 2020

stof commented May 18, 2020

stof commented May 18, 2020

[Validator] add Validation::createCallable() #31466

[Validator] add Validation::createCallable() #31466

Conversation

janvernieuwe commented May 10, 2019 • edited by lyrixx Loading

Simperfit left a comment

Choose a reason for hiding this comment

janvernieuwe commented May 13, 2019

ro0NL commented Jun 4, 2019

janvernieuwe commented Jun 7, 2019 • edited Loading

janvernieuwe commented Jul 26, 2019

nicolas-grekas Nov 5, 2019

Choose a reason for hiding this comment

janvernieuwe Nov 29, 2019

Choose a reason for hiding this comment

ro0NL left a comment

Choose a reason for hiding this comment

nicolas-grekas commented Jan 21, 2020

janvernieuwe commented Jan 22, 2020

nicolas-grekas left a comment

Choose a reason for hiding this comment

fabpot commented Feb 4, 2020

stof commented May 18, 2020

nicolas-grekas commented May 18, 2020

stof commented May 18, 2020

stof commented May 18, 2020

stof commented May 18, 2020

janvernieuwe commented May 10, 2019 •

edited by lyrixx

Loading

janvernieuwe commented Jun 7, 2019 •

edited

Loading