Skip to content

[PropertyAccess] Add missing property to PropertyAccessor #31477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2019

Conversation

vudaltsov
Copy link
Contributor

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@vudaltsov
Copy link
Contributor Author

Status: Needs Review

Copy link
Contributor

@Simperfit Simperfit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have a test case for the exception ?

@nicolas-grekas nicolas-grekas force-pushed the property-accessor-fix branch from 5290750 to b1d3736 Compare May 12, 2019 11:08
@nicolas-grekas
Copy link
Member

Thank you @vudaltsov.

@nicolas-grekas nicolas-grekas merged commit b1d3736 into symfony:4.2 May 12, 2019
nicolas-grekas added a commit that referenced this pull request May 12, 2019
…(vudaltsov)

This PR was squashed before being merged into the 4.2 branch (closes #31477).

Discussion
----------

[PropertyAccess] Add missing property to PropertyAccessor

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

b1d3736 [PropertyAccess] Add missing property to PropertyAccessor
This was referenced May 22, 2019
@vudaltsov vudaltsov deleted the property-accessor-fix branch June 27, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants