Skip to content

[PhpUnitBridge] Fix some errors when using serialized deprecations #31478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[PhpUnitBridge] Fix some errors when using serialized deprecations #31478

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09bd6b7
[PhpUnitBridge] Fix error when setting "self" property value
l-vo May 6, 2019
e827025
[PhpUnitBridge] Use serialized trace when using serialized deprecation
l-vo May 8, 2019
d79dbec
[PhpUnitBridge] Remove useless is/else statement
l-vo May 15, 2019
edfdccf
[PhpUnitBridge] Remove unused method
l-vo May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[PhpUnitBridge] Remove unused method
  • Loading branch information
@l-vo
l-vo committed Jun 2, 2019
commit edfdccff13d477c7dabd5a6fb03cfa1c10cad866
15 changes: 0 additions & 15 deletions src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,19 +296,4 @@ public function toString()
"\n".str_replace(' '.getcwd().\DIRECTORY_SEPARATOR, ' ', $exception->getTraceAsString()).
"\n";
}

private function getPackageFromLine(array $line)
{
if (!isset($line['file'])) {
return 'internal function';
}
if (!$this->pathOriginatesFromVendor($line['file'])) {
return 'source code';
}
try {
return $this->getPackage($line['file']);
} catch (\RuntimeException $e) {
return 'unknown';
}
}
}