Update dependencies in the main component #31480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, good catch. |
|
Thinking twice, bridges should be in the replace section too, so that flex can apply its extra.symfony.require constraints on them! |
|
Updated according to @nicolas-grekas advice, thanks. |
fabpot
approved these changes
May 13, 2019
|
Thank you @DavidPrevot. |
fabpot
added a commit
that referenced
this pull request
May 13, 2019
This PR was squashed before being merged into the 4.3 branch (closes #31480). Discussion ---------- Update dependencies in the main component | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | The doctrine/collections and psr/simple-cache dependencies have already been demoted to require-dev in the relevant components. BTW, I wonder if symfony/mailer (and symfony/*-mailer bridges) should be provided in the main composer.json too. Commits ------- 96f4626 Update dependencies in the main component
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doctrine/collections and psr/simple-cache dependencies have already been demoted to require-dev in the relevant components.
BTW, I wonder if symfony/mailer (and symfony/*-mailer bridges) should be provided in the main composer.json too.