-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Validator] Autovalidation: skip readonly props #31481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
May 12, 2019
sroze
reviewed
May 12, 2019
src/Symfony/Component/Validator/Tests/Mapping/Loader/PropertyInfoLoaderTest.php
Show resolved
Hide resolved
maxhelias
approved these changes
May 12, 2019
fabpot
approved these changes
May 13, 2019
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
May 13, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Validator] Autovalidation: skip readonly props | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a Read-only properties (such as an autogenerated ID) must be skipped during the validation (it makes no sense to validate a RO property anyway). This is an allowed BC break because this feature will be introduced in 4.3. Commits ------- e7dc5e1 [Validator] Autovalidation: skip readonly props
fabpot
added a commit
that referenced
this pull request
May 13, 2019
… (dunglas) This PR was merged into the 4.3 branch. Discussion ---------- [Doctrine][PropertyInfo] Detect if the ID is writeable | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a Companion of #31481. Allows to detect that ids with a generated value aren't writable (because the DBMS will generate the ID by itself). It could be considered as a bug fix or as a new feature. I prefer to not merge in in 3.4. However, it becomes necessary for autovalidation to work with such entities, so it should be in 4.3: ```php /** * @entity */ class Foo { /** * @id * @GeneratedValue(strategy="AUTO") * @column(type="integer") */ public $id; } ``` Commits ------- 4598235 [Doctrine][PropertyInfo] Detect if the ID is writeable
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read-only properties (such as an autogenerated ID) must be skipped during the validation (it makes no sense to validate a RO property anyway).
This is an allowed BC break because this feature will be introduced in 4.3.