[DI] deprecate short callables in yaml #31543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
May 19, 2019
ogizanagi
approved these changes
May 20, 2019
| } | ||
|
|
||
| if (false !== strpos($callable, ':') && false === strpos($callable, '::')) { | ||
| $parts = explode(':', $callable); | ||
|
|
||
| @trigger_error(sprintf('Using short %s syntax for service "%s" is deprecated since Symfony 4.4, use "[\'@%s\', \'%s\']" instead.', $parameter, $id, ...$parts), E_USER_DEPRECATED); |
There was a problem hiding this comment.
If $parameter is something that the user types ... then we should replace short %s syntax by short "%s" syntax to avoid potential confusions.
There was a problem hiding this comment.
it can only be factory of configurator, so no issue here.
4eb81ab to
ec906b6
Compare
|
UPGRADE+CHANGELOG files updated. |
Tobion
reviewed
May 22, 2019
Tobion
approved these changes
May 22, 2019
ec906b6 to
f8a04fd
Compare
nicolas-grekas
added a commit
that referenced
this pull request
May 22, 2019
This PR was merged into the 4.4-dev branch. Discussion ---------- [DI] deprecate short callables in yaml | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#11589 This deprecates defining factories as `foo:method` instead of `['@foo', 'method']` in yaml. This is confusing syntax and misses the opportunity to raise an error when one does a typo and uses a single colon instead of two. This basically reverts #19190 Commits ------- f8a04fd [DI] deprecate short callables in yaml
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
May 29, 2019
…rekas) This PR was merged into the 4.2 branch. Discussion ---------- Remove short factories/configurators examples This PR reverts #7203, as short factories are more confusing than useful. I'm proposing to deprecate them in symfony/symfony#31543 Note that some of this patch can (should) be adapted to 3.4 also. Commits ------- e8cfa6e Remove short factories/configurators examples
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates defining factories as
foo:methodinstead of['@foo', 'method']in yaml.This is confusing syntax and misses the opportunity to raise an error when one does a typo and uses a single colon instead of two.
This basically reverts #19190