-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form] Improved ChoiceList implementation and made form naming more restrictive #3156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
87b16e7
[Form] Greatly improved ChoiceListInterface and all of its implementa…
webmozart e1fc5a5
[Form] Restricted form names to specific characters to (1) fix genera…
webmozart 28d2f6d
Removed duplicated lines from UPGRADE file
webmozart d72900e
[Form] Incorporated changes suggested in PR comments
webmozart f533ef0
[Form] Added ChoiceView class for passing choice-related data to the …
webmozart 18f92cd
[Form] Fixed double choice fixing
webmozart c26b47a
[Form] Made query parameter name generated by ORMQueryBuilderLoader u…
webmozart 7c70976
[Form] Fixed text in UPGRADE file
webmozart 5f6f75c
[Form] Fixed outstanding issues mentioned in the PR
webmozart 399af27
[Form] Implemented checks to assert that values and indices generated…
webmozart b154f7c
[Form] Fixed docblock and unneeded use statement
webmozart 600cec7
[Form] Added missing entries to CHANGELOG and UPGRADE
webmozart 8dc78bd
[Form] Fixed YODA issues
webmozart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a problem to have a choice-list containing an empty string ? What will happen if a choice-list contain an empty string ?
I see multiple problems with the default strategy, and I can't use the old strategy because of the empty string problem:
Point 1 could be addressed by hashing the original value to generate the value (if values aren't objects).
Point 2 can only be addressed by not using this strategy (but what about empty strings ?)
Point 3 can be addressed by exposing the mapping to the client side, but this seems to become complicated.