Skip to content

[Mime][HttpFoundation] Added mime type audio/x-hx-aac-adts #31565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2019
Merged

[Mime][HttpFoundation] Added mime type audio/x-hx-aac-adts #31565

merged 1 commit into from
May 23, 2019

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Replaces #31464

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone May 21, 2019
@nicolas-grekas nicolas-grekas mentioned this pull request May 21, 2019
Closed
@fabpot
Copy link
Member

fabpot commented May 21, 2019

Shouldn't we contribute that change upstream? Because it will be lost next time we sync with the Apache list.

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented May 21, 2019 •
edited
Loading

I agree, @ifaridjalilov here are the two files we use as a source
https://github.com/minad/mimemagic/blob/master/script/freedesktop.org.xml
and
https://svn.apache.org/repos/asf/httpd/httpd/trunk/docs/conf/mime.types
Could you submit this update there please?

@fabpot fabpot removed this from the 4.3 milestone May 22, 2019
@nicolas-grekas nicolas-grekas modified the milestone: 4.3 May 22, 2019
@nicolas-grekas
Copy link
Member Author

@fabpot I just ran the update_mime_types.php and the additions were not removed, so this is safe.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone May 22, 2019
@nicolas-grekas
Copy link
Member Author

Thank you @ifaridjalilov.

@nicolas-grekas nicolas-grekas merged commit 67fbae1 into symfony:4.3 May 23, 2019
nicolas-grekas added a commit that referenced this pull request May 23, 2019
@nicolas-grekas
bug #31565 [Mime][HttpFoundation] Added mime type audio/x-hx-aac-adts…
6bd10a8 
… (ifaridjalilov)

This PR was merged into the 4.3 branch.

Discussion
----------

[Mime][HttpFoundation] Added mime type audio/x-hx-aac-adts

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Replaces #31464

Commits
-------

67fbae1 [Mime][HttpFoundation] Added mime type audio/x-hx-aac-adts
@nicolas-grekas nicolas-grekas deleted the mime-aac branch May 28, 2019 10:30
@fabpot fabpot mentioned this pull request May 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug HttpFoundation Status: Needs Review
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @carsonbot @ifaridjalilov