[Workflow] Do not trigger extra guards #31584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0eb9df to
72cec55
Compare
|
@lyrixx thank you so much! |
Simperfit
approved these changes
May 23, 2019
72cec55 to
07c7fa8
Compare
chalasr
approved these changes
May 26, 2019
With this patch, guard are executed only on wanted transitions
07c7fa8 to
ad06197
Compare
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
May 27, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Workflow] Do not trigger extra guards | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31582 | License | MIT | Doc PR | --- With this patch, guards are executed only on wanted transitions **Note for merger**: This is already fixed (in a different manner) in 4.2, So this patch should not be included in 4.2, instead take: #31585 or discard changes of Workflow class but keep tests Commits ------- ad06197 [Workflow] Do not trigger extra guard
This was referenced May 28, 2019
Merged
Merged
Merged
|
@rumours86 Don't worry, I checked few days ago and everything was fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, guards are executed only on wanted transitions
Note for merger: This is already fixed (in a different manner) in 4.2, So this patch should not be included in 4.2, instead take: #31585 or discard changes of Workflow class but keep tests