[Security] add PasswordEncoderInterface::needsRehash() #31594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eae871b to
7daff22
Compare
Simperfit
approved these changes
May 23, 2019
chalasr
approved these changes
May 23, 2019
d91d302 to
25c197b
Compare
25c197b to
e30c8c2
Compare
e30c8c2 to
50590dc
Compare
|
friendly ping @symfony/deciders |
xabbuh
reviewed
Jun 3, 2019
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function needsRehash(string $encoded): bool |
There was a problem hiding this comment.
Should we add a check for BCrypt passwords too?
There was a problem hiding this comment.
It's deprecated so I don't think we should improve it further.
Tobion
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
Agree with this. It's best practice to have the hash contain the algo, salt, and options and then determine based on this if a rehash is needed.
But going this way contradics the old way of doing that using a salt parameter and UserPasswordEncoderInterface. So I think we should deprecate
- the salt paramter in
- maybe also
|
Thank you @nicolas-grekas. |
chalasr
pushed a commit
that referenced
this pull request
Jun 4, 2019
… (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [Security] add PasswordEncoderInterface::needsRehash() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Split from #31153, with tests. Commits ------- 50590dc [Security] add PasswordEncoderInterface::needsRehash()
35 tasks
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #31153, with tests.