Skip to content

[Security] add MigratingPasswordEncoder #31597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented May 23, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Split from #31153: the proposed MigratingPasswordEncoder is able to validate password using a chain of encoders, and encodes new them using the best-provided algorithm.

This chained encoder is used when the "auto" algorithm is configured. This is seamless for 4.3 app.

@rpkamp
Copy link
Contributor

rpkamp commented May 25, 2019

Liking the name MigratingPasswordEncoder. Much better than ChainedPasswordEncoder - it conveys much more intent! 👍

@nicolas-grekas nicolas-grekas changed the base branch from master to 4.4 June 2, 2019 20:04
@nicolas-grekas nicolas-grekas force-pushed the sec-migrating-encoder branch from b4bc5de to 765f14c Compare June 4, 2019 06:31
@nicolas-grekas
Copy link
Member Author

Rebased, ready.

@fabpot
Copy link
Member

fabpot commented Jun 4, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 765f14c into symfony:4.4 Jun 4, 2019
fabpot added a commit that referenced this pull request Jun 4, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[Security] add MigratingPasswordEncoder

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Split from #31153: the proposed `MigratingPasswordEncoder` is able to validate password using a chain of encoders, and encodes new them using the best-provided algorithm.

This chained encoder is used when the "auto" algorithm is configured. This is seamless for 4.3 app.

Commits
-------

765f14c [Security] add MigratingPasswordEncoder
@nicolas-grekas nicolas-grekas deleted the sec-migrating-encoder branch June 5, 2019 14:41
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants