[Translation] Fixed issue with new vs old TranslatorInterface in TranslationDataCollector #31599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good indeed, but this should go to 4.2 where the bug was introduced (#28375) |
…slationDataCollector
|
Thank you @althaus. |
nicolas-grekas
added a commit
that referenced
this pull request
May 23, 2019
…ace in TranslationDataCollector (althaus) This PR was submitted for the master branch but it was squashed and merged into the 4.2 branch instead (closes #31599). Discussion ---------- [Translation] Fixed issue with new vs old TranslatorInterface in TranslationDataCollector I'm not sure when this gets executed, but overriding `$trans` directly after the `if` simply looks wrong. | Q | A | ------------- | --- | Branch? | 4.3-beta2, but last change at that position is a couple of months | Bug fix? | yes, me thinks | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT Cheers Matthias Commits ------- a1677c7 [Translation] Fixed issue with new vs old TranslatorInterface in TranslationDataCollector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure when this gets executed, but overriding
$transdirectly after theifsimply looks wrong.Cheers
Matthias