[HttpFoundation] Do not set X-Accel-Redirect for paths outside of X-Accel-Mapping #31604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccel-Mapping Currently BinaryFileResponse, when configured with X-Accel-Redirect sendfile type, will only substitute file paths specified in X-Accel-Mapping. But if the provided file path does not have a defined prefix, then the resulting header will include the absolute path. Nginx expects a valid URI, therefore this will result in an issue that is very hard to detect and debug as it will not show up in error logs and instead the request would just hang for some time and then be re-served without query parameters(?).
fabpot
approved these changes
May 25, 2019
Simperfit
approved these changes
May 25, 2019
nicolas-grekas
approved these changes
May 28, 2019
|
Don't we have the same issue in 3.4? |
Yes, this affects all versions. But fix requires refactor for 3.4. |
|
@vilius-g It means that we first need a PR on 3.4. Can you work on one? |
|
OK, I can make this for 3.4. |
|
Thank you! |
|
Replaced by #31654 |
nicolas-grekas
added a commit
that referenced
this pull request
May 29, 2019
…side of X-Accel-Mapping (vilius-g) This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] Do not set X-Accel-Redirect for paths outside of X-Accel-Mapping | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | #31604 but refactored for 3.4 Commits ------- a662f61 [HttpFoundation] Do not set X-Accel-Redirect for paths outside of X-Accel-Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
BinaryFileResponse, when configured withX-Accel-Redirectsendfile type, will only substitute file paths specified inX-Accel-Mapping. But if the provided file path does not have a defined prefix, then the resulting header will include absolute path. Nginx expects a valid URI, therefore this will result in an issue that is very hard to detect and debug as it will not show up in error logs and instead the request would just hang for some time and will be re-served without query parameters(?).