[Messenger] Disable the SchemaAssetsFilter when setup the transport #31625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vincenttouzet
commented
May 26, 2019
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #31623 |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
|
Tests seem broken |
Yes I'm on it 😉 |
638cffd to
1536f42
Compare
1536f42 to
8cbb8f8
Compare
|
Well the fix is uglier than I thought 🤔 As of Doctrine 2.9 the method to configure the assets filter has changed : doctrine/dbal@111e42d doctrine-dbal 2.9 introduce the new methods So I need to try if the method exists before |
|
Quick work - thanks! Yea, that got ugly :). I can't think of another way either - can anyone else? If not, I think we need this - without it, it's an even uglier situation for the user. |
fabpot
approved these changes
May 27, 2019
|
Thank you @vincenttouzet. |
fabpot
added a commit
that referenced
this pull request
May 27, 2019
…transport (vincenttouzet) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Disable the SchemaAssetsFilter when setup the transport | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #31623 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Commits ------- 8cbb8f8 [Messenger] Disable the SchemaAssetsFilter when setup the transport
Merged
fabpot
added a commit
that referenced
this pull request
Apr 8, 2024
…es on setup (MatTheCat) This PR was merged into the 5.4 branch. Discussion ---------- [Messenger] Make Doctrine connection ignore unrelated tables on setup | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #49108 | License | MIT Introspecting the whole database can cause issues like Doctrine crashing on unknown column types. This PR updates the schema assets filter (added by #31625) to only consider the messages table, as it is the only one a connection setup needs to care about. Commits ------- 22dab67 [Messenger] Make Doctrine connection ignore unrelated tables on setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.