Create an abstract HTTP transport and extend it in all HTTP transports #31650

bocharsky-bw · 2019-05-28T11:43:37Z

Q	A
Branch?	4.3
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	no
License	MIT
Doc PR	no

Right now when you try to use an HTTP transport e.g. Mailgun w/o HTTP client installed - the error message is:

Attempted to load class "HttpClient" from namespace "Symfony\Component\HttpClient".
Did you forget a "use" statement for "Http\Client\HttpClient"?

Not clear enough about what to do. After this PR the error message will be:

You cannot use "Symfony\Component\Mailer\Bridge\Mailgun\Http\MailgunTransport" as the HttpClient component is not installed. Try running "composer require symfony/http-client".

Actually, we already have a similar check for API:

symfony/src/Symfony/Component/Mailer/Transport/Http/Api/AbstractApiTransport.php

Lines 37 to 44 in 2c9a196

    
           $this->client = $client; 
        
           if (null === $client) { 
        
               if (!class_exists(HttpClient::class)) { 
        
                   throw new \LogicException(sprintf('You cannot use "%s" as the HttpClient component is not installed. Try running "composer require symfony/http-client".', __CLASS__)); 
        
               } 
        
               $this->client = HttpClient::create(); 
        
           }

fabpot · 2019-05-28T11:59:48Z

Thank you @bocharsky-bw.

…P transports (bocharsky-bw) This PR was merged into the 4.3 branch. Discussion ---------- Create an abstract HTTP transport and extend it in all HTTP transports | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | no Right now when you try to use an HTTP transport e.g. Mailgun w/o HTTP client installed - the error message is: > Attempted to load class "HttpClient" from namespace "Symfony\Component\HttpClient". Did you forget a "use" statement for "Http\Client\HttpClient"? Not clear enough about what to do. After this PR the error message will be: > You cannot use "Symfony\Component\Mailer\Bridge\Mailgun\Http\MailgunTransport" as the HttpClient component is not installed. Try running "composer require symfony/http-client". Actually, we already have a similar check for API: https://github.com/symfony/symfony/blob/2c9a1960a164a857cd551881b580266bc77bdafa/src/Symfony/Component/Mailer/Transport/Http/Api/AbstractApiTransport.php#L37-L44 Commits ------- 3c8d63c Create an abstract HTTP transport and extend it in all HTTP transports

carsonbot added the Status: Needs Review label May 28, 2019

bocharsky-bw changed the base branch from master to 4.3 May 28, 2019 11:44

bocharsky-bw changed the base branch from 4.3 to master May 28, 2019 11:44

Create an abstract HTTP transport and extend it in all HTTP transports

3c8d63c

bocharsky-bw changed the base branch from master to 4.3 May 28, 2019 11:51

bocharsky-bw force-pushed the patch-5 branch from 32d6357 to 3c8d63c Compare May 28, 2019 11:51

nicolas-grekas approved these changes May 28, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels May 28, 2019

nicolas-grekas added this to the 4.3 milestone May 28, 2019

Simperfit approved these changes May 28, 2019

View reviewed changes

fabpot approved these changes May 28, 2019

View reviewed changes

fabpot merged commit 3c8d63c into symfony:4.3 May 28, 2019

bocharsky-bw deleted the patch-5 branch May 28, 2019 12:02

fabpot mentioned this pull request May 28, 2019

Release v4.3.0-RC1 #31652

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create an abstract HTTP transport and extend it in all HTTP transports #31650

Create an abstract HTTP transport and extend it in all HTTP transports #31650

bocharsky-bw commented May 28, 2019

fabpot commented May 28, 2019

	$this->client = $client;
	if (null === $client) {
	if (!class_exists(HttpClient::class)) {
	throw new \LogicException(sprintf('You cannot use "%s" as the HttpClient component is not installed. Try running "composer require symfony/http-client".', __CLASS__));
	}

	$this->client = HttpClient::create();
	}

Create an abstract HTTP transport and extend it in all HTTP transports #31650

Create an abstract HTTP transport and extend it in all HTTP transports #31650

Conversation

bocharsky-bw commented May 28, 2019

fabpot commented May 28, 2019