[HTTP Foundation] Deprecate passing argument to method Request::isMethodSafe() #31658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de78c59 to
d3e0689
Compare
|
Thanks, please rebase and retarget for branch 4.4, as we don't add deprecations on other branches. |
|
@nicolas-grekas Done |
|
@dFayet It looks like your merged a branch here. It makes the pull request not-mergeable on our side. Can you rebase your branch (it will remove the merge commit)? |
3a4321d to
6aa78cf
Compare
|
@fabpot done |
fabpot
requested changes
Jun 4, 2019
fabpot
approved these changes
Jun 4, 2019
|
Can you have a look at the tests, they seem to be broken because of these changes (low). |
|
@fabpot Done for low. Is there anything to be done for the high one? |
7fc0df1 to
59fa1bd
Compare
|
Thank you @dFayet. |
fabpot
added a commit
that referenced
this pull request
Jun 5, 2019
… Request::isMethodSafe() (dFayet) This PR was squashed before being merged into the 4.4 branch (closes #31658). Discussion ---------- [HTTP Foundation] Deprecate passing argument to method Request::isMethodSafe() | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #31323 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | <!-- required for new features --> Passing argument to `Request::isMethodSafe()` should have been deprecated in 4.1. As mentionned there: https://github.com/symfony/http-foundation/blob/master/Request.php#L1435-L1452 We also remove Exceptions throwed when you call `Request::isMethodSafe()` or `Request::isMethodSafe(true)` Commits ------- 59fa1bd [HTTP Foundation] Deprecate passing argument to method Request::isMethodSafe()
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing argument to
Request::isMethodSafe()should have been deprecated in 4.1. As mentionned there: https://github.com/symfony/http-foundation/blob/master/Request.php#L1435-L1452We also remove Exceptions throwed when you call
Request::isMethodSafe()orRequest::isMethodSafe(true)