Skip to content

[BrowserKit] remove deprecated code #31674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Simperfit
Copy link
Contributor

@Simperfit Simperfit commented May 29, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none.
License MIT
Doc PR none

This PR removed all deprecated code from BrowserKit.

@nicolas-grekas
Copy link
Member

Please submit ready PR on the topic, otherwise, we're going to collapse under the load.
Please take time to properly fill in the PR template, cleanup tests (including unused fixtures, etc.)
Removing legacy code might look like an easy task but it must be a very careful one.

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone May 29, 2019
@Simperfit Simperfit force-pushed the feature/remove-deprecated-code-from-browsetKit branch 2 times, most recently from c943a26 to 9861324 Compare June 5, 2019 05:59
@Simperfit Simperfit marked this pull request as ready for review June 5, 2019 05:59
@Simperfit Simperfit force-pushed the feature/remove-deprecated-code-from-browsetKit branch from 9861324 to b7b9a61 Compare June 5, 2019 06:00
@Simperfit Simperfit force-pushed the feature/remove-deprecated-code-from-browsetKit branch from b7b9a61 to e05de9e Compare June 5, 2019 06:02
@Simperfit
Copy link
Contributor Author

@nicolas-grekas this is ready ! the big change is linked to the fact that I'm moving old Client class to the new AbstractBrowser class, the rest is test update :).

@nicolas-grekas
Copy link
Member

Thank you @Simperfit.

@nicolas-grekas nicolas-grekas merged commit e05de9e into symfony:master Jun 5, 2019
nicolas-grekas added a commit that referenced this pull request Jun 5, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

[BrowserKit] remove deprecated code

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |none.   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | none <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

This PR removed all deprecated code from BrowserKit.

Commits
-------

e05de9e [BrowserKit] remove deprecated code
@Simperfit Simperfit deleted the feature/remove-deprecated-code-from-browsetKit branch June 5, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants