[ErrorCatcher][ExceptionHandler] Handle \Throwable #31694
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
May 29, 2019
| @@ -85,7 +85,7 @@ public function testHeaders() | |||
|
|
|||
| ob_start(); | |||
| $handler->sendPhpResponse(new MethodNotAllowedHttpException(['POST'])); | |||
| $response = ob_get_clean(); | |||
| ob_get_clean(); | |||
fancyweb
commented
May 29, 2019
| }); | ||
|
|
||
| $handler->handle($exception); | ||
| $handler->handle(new \Exception()); | ||
| ob_end_flush(); // Necessary because of this PHP bug : https://bugs.php.net/bug.php?id=76563 |
There was a problem hiding this comment.
Lost more than 4 hours on this. If someone wants to look at it, just put this in a controller :
$handler = ExceptionHandler::register();
$handler->setHandler(function ($e) {
echo 'foo';
});
$handler->handle(new \RuntimeException('bar'));
dump(ob_get_clean()); die();
It will dump the full content (default error handler content + "foo"). If you comment the dump, only "foo" is actually rendered.
derrabus
reviewed
Jun 6, 2019
bf577d0 to
2653752
Compare
|
@nicolas-grekas @yceruto Just rebased this on master to apply the changes on the new Since it touches 2 components, should I split this ? |
2653752 to
64d02cb
Compare
Tobion
added a commit
that referenced
this pull request
Jun 28, 2019
… the ErrorCatcher component (fancyweb) This PR was merged into the 5.0-dev branch. Discussion ---------- [Debug] Remove all deprecated classes that were moved to the ErrorCatcher component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | - #31694 (comment) Commits ------- 8ce3a89 [Debug] Remove all deprecated classes that were moved to the ErrorCatcher component
|
The plan is to remove ExceptionHandler from ErrorHandler if you want to have a look. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 23, 2019
…(fancyweb) This PR was merged into the 3.4 branch. Discussion ---------- [Debug][ExceptionHandler] Add tests for custom handlers | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - In #31694 I mixed many things but the whole PR was closed. I wrote some tests for custom handlers + the handle tests don't use mock anymore I think they are useful even if the `ExceptionHandler` will disappear in the new component because it will still exists in 4.4 for the next 3 years. Commits ------- c53e253 [Debug][ExceptionHandler] Add tests for custom handlers
symfony-splitter
pushed a commit
to symfony/debug
that referenced
this pull request
Jul 23, 2019
…(fancyweb) This PR was merged into the 3.4 branch. Discussion ---------- [Debug][ExceptionHandler] Add tests for custom handlers | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - In symfony/symfony#31694 I mixed many things but the whole PR was closed. I wrote some tests for custom handlers + the handle tests don't use mock anymore I think they are useful even if the `ExceptionHandler` will disappear in the new component because it will still exists in 4.4 for the next 3 years. Commits ------- c53e25332a [Debug][ExceptionHandler] Add tests for custom handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #28954
I also removed an unused test file + added a test for the new behavior + added 3 tests when you use custom handlers.