[Serializer] Unified normalizers/encoders config through default context solely #31699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php
Show resolved
Hide resolved
|
Rebased & green (except Lock on AppVeyor which is... well, locking the build) |
| @@ -93,7 +91,7 @@ public function testNormalize() | |||
| ->expects($this->once()) | |||
| ->method('normalize') | |||
| ->with($object, 'any') | |||
| ->will($this->returnValue('string_object')) | |||
| ->willReturn('string_object') | |||
There was a problem hiding this comment.
I don't know why fabbot is adding these now, but this should be done on lower branches first and reverted here
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2019
… default context solely (ogizanagi) This PR was squashed before being merged into the 5.0-dev branch (closes #31699). Discussion ---------- [Serializer] Unified normalizers/encoders config through default context solely | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #28709 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A As planned in #28709. Split into two commits to ease review. Commits ------- 914577e [Serializer] Unified normalizers/encoders config through default context solely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As planned in #28709.
Split into two commits to ease review.