Skip to content

[MonologBridge] RouteProcessor class is now final to ease the the removal of deprecated event #31700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Simperfit
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR none

To ease the removal of deprecated events this class has been made final as said in #31672 (comment)

@nicolas-grekas nicolas-grekas added this to the next milestone May 29, 2019
@Simperfit Simperfit force-pushed the made-route-processor-final-to-remove-the-deprecated-event branch from b2d22a2 to 743ae35 Compare May 29, 2019 17:25
@Simperfit Simperfit force-pushed the made-route-processor-final-to-remove-the-deprecated-event branch from 743ae35 to 9646364 Compare May 31, 2019 08:47
@Simperfit
Copy link
Contributor Author

done @nicolas-grekas

@nicolas-grekas
Copy link
Member

Thank you @Simperfit.

@nicolas-grekas nicolas-grekas merged commit 9646364 into symfony:4.4 May 31, 2019
nicolas-grekas added a commit that referenced this pull request May 31, 2019
…ase the the removal of deprecated event (Simperfit)

This PR was merged into the 4.4 branch.

Discussion
----------

[MonologBridge] RouteProcessor class is now final to ease the the removal of deprecated event

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | none  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | none  <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

To ease the removal of deprecated events this class has been made final as said in #31672 (comment)

Commits
-------

9646364 [MonologBridge] RouteProcessor class is now final to ease the the removal of deprecated event
@Simperfit Simperfit deleted the made-route-processor-final-to-remove-the-deprecated-event branch May 31, 2019 10:51
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants