[FrameworkBundle] Remove support for the bundle:controller:action notation #31702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please have a look at tests? |
c8e08bd to
295766c
Compare
|
@nicolas-grekas done |
chalasr
reviewed
May 29, 2019
|
There are test failures that should be fixed with #31713 |
a12b288 to
a6a0df2
Compare
Tobion
reviewed
May 30, 2019
chalasr
reviewed
May 30, 2019
src/Symfony/Bundle/FrameworkBundle/Tests/Routing/DelegatingLoaderTest.php
Outdated
Show resolved
Hide resolved
Tobion
reviewed
May 30, 2019
src/Symfony/Bundle/FrameworkBundle/Controller/ControllerResolver.php
Outdated
Show resolved
Hide resolved
chalasr
reviewed
May 30, 2019
Tobion
reviewed
May 30, 2019
src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php
Outdated
Show resolved
Hide resolved
c465675 to
c4ed065
Compare
|
LGTM, but we should probably wait on #31739 and then rebase. |
|
#31739 has been merged now. |
e13e4d5 to
4ba93f2
Compare
|
@fabpot PR rebased with master |
fabpot
requested changes
Jun 4, 2019
src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php
Outdated
Show resolved
Hide resolved
4ba93f2 to
4574197
Compare
|
Tests and comments fixed. |
fabpot
approved these changes
Jun 4, 2019
|
Tests are broken. Can you have a look @Simperfit? |
4574197 to
29e3c2f
Compare
|
Tests are fixed now @fabpot. |
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Jun 4, 2019
…er:action notation (Simperfit) This PR was merged into the 5.0-dev branch. Discussion ---------- [FrameworkBundle] Remove support for the bundle:controller:action notation | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR |none no mention in the docs <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> This remove the ResolveControllerNameSubscriber since it is deprecated, it ease the cleaning of HttpKernel see #31672 (comment) Commits ------- 29e3c2f [FrameworkBundle] remove deprecater controller a:b:c notation
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jun 6, 2019
…der` service (yceruto) This PR was merged into the 5.0-dev branch. Discussion ---------- [FrameworkBundle] Fixed replace argument of `routing.loader` service | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Fix symfony/symfony#31702 > (1/1) OutOfBoundsException The index "2" is not in the range [0, 1]. https://github.com/symfony/symfony/blob/bd8d8a2cfd50dffb4aa07908865931fb82a9e7bf/src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php#L33 Commits ------- 5e2e79dbb9 Fixed replace argument of `routing.loader` service
nicolas-grekas
added a commit
that referenced
this pull request
Jun 6, 2019
…der` service (yceruto) This PR was merged into the 5.0-dev branch. Discussion ---------- [FrameworkBundle] Fixed replace argument of `routing.loader` service | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Fix #31702 > (1/1) OutOfBoundsException The index "2" is not in the range [0, 1]. https://github.com/symfony/symfony/blob/bd8d8a2cfd50dffb4aa07908865931fb82a9e7bf/src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php#L33 Commits ------- 5e2e79d Fixed replace argument of `routing.loader` service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove the ResolveControllerNameSubscriber since it is deprecated, it ease the cleaning of HttpKernel see #31672 (comment)