Skip to content

[FrameworkBundle] fix deprecation of fragments by using FQCN #31708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FrameworkBundle] fix deprecation of fragments by using FQCN #31708

wants to merge 1 commit into from

Conversation

Simperfit
Copy link
Contributor

Q A
Branch? 4.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets non
License MIT
Doc PR non

This fixes the error I got in https://travis-ci.org/symfony/symfony/jobs/538890475 and I don't understand why it doesn't fail anywhere else.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone May 29, 2019
@nicolas-grekas
Copy link
Member

We're missing something, this breaks tests on 4.3.
Anyone with a clue?

@Simperfit Simperfit force-pushed the fix-fragment-template-with-fqcn-call branch from 34bab1b to 80e45c1 Compare May 29, 2019 21:24
@Simperfit
Copy link
Contributor Author

test fixed

@chalasr
Copy link
Member

chalasr commented May 29, 2019

I don't understand why it doesn't fail anywhere else.

Because the ResolveControllerNameSubscriber class that you are removing in #31702 was preventing the deprecation from being triggered as it converts controller names that use the deprecated notation to a one that use a valid notation ( class::method). The test case should have been broken way before your PRs.

This means that we also miss a deprecation notice in ResolveControllerNameSubscriber since 4.1 which we may want to add in 4.4 to make the BC layer complete.

@Tobion
Copy link
Contributor

Tobion commented May 30, 2019

I didn't see your PR. Here is mine which is a little more complete: #31713

@fabpot
Copy link
Member

fabpot commented May 30, 2019

closes in favor of #31713

@fabpot fabpot closed this May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@Simperfit @nicolas-grekas @chalasr @Tobion @fabpot @carsonbot