Skip to content

[DoctrineBridge][Validator] do not enable validator auto mapping by default #31749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 30, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets part of #31715, #31752
License MIT
Doc PR

@phansys
Copy link
Contributor

phansys commented May 30, 2019

I confirm this PR solves the issue reported at #31743.

Copy link
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Sylius, fixes the issue, thanks! 🎉

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit a3555fc into symfony:4.3 May 31, 2019
nicolas-grekas added a commit that referenced this pull request May 31, 2019
…apping by default (xabbuh)

This PR was merged into the 4.3 branch.

Discussion
----------

[DoctrineBridge][Validator] do not enable validator auto mapping by default

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | part of #31715, #31752
| License       | MIT
| Doc PR        |

Commits
-------

a3555fc do not enable validator auto mapping by default
@xabbuh xabbuh deleted the issue-31715 branch May 31, 2019 07:44
@fabpot fabpot mentioned this pull request Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants