[Security\Core] Make SodiumPasswordEncoder validate BCrypt-ed passwords #31763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
May 31, 2019
|
Thank you @nicolas-grekas. |
chalasr
pushed a commit
that referenced
this pull request
May 31, 2019
…-ed passwords (nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [Security\Core] Make SodiumPasswordEncoder validate BCrypt-ed passwords | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31758 | License | MIT | Doc PR | - Otherwise, the promise of the "auto" mode doesn't work. Commits ------- c0fc456 [Security\Core] Make SodiumPasswordEncoder validate BCrypt-ed passwords
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Dec 3, 2019
…David Brooks) This PR was merged into the 4.4 branch. Discussion ---------- [Security/Core] Fix checking for SHA256/SHA512 passwords | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #... <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- The code to validate bcrypt passwords (#31763) needs to include SHA256 and SHA512-hashed passwords. These are used on RedHat (and derived) systems. Since SHA256/512 don't appear to have a limit of 72 characters, I simply created a new if() block. --> Commits ------- 799c85b [Security/Core] Fix checking for SHA256/SHA512 passwords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the promise of the "auto" mode doesn't work.