Skip to content

[Form] do not iterate twice on the extended types #31779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2019
Merged

[Form] do not iterate twice on the extended types #31779

merged 1 commit into from
Jun 1, 2019

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented May 31, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR

Simplification of #31703

@Tobion Tobion requested a review from xabbuh as a code owner May 31, 2019 22:16
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jun 1, 2019
@nicolas-grekas
Copy link
Member

Thank you @Tobion.

@nicolas-grekas nicolas-grekas merged commit 75179d3 into symfony:master Jun 1, 2019
nicolas-grekas added a commit that referenced this pull request Jun 1, 2019
@nicolas-grekas
minor #31779 [Form] do not iterate twice on the extended types (Tobion)
371dfc7 
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Form] do not iterate twice on the extended types

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        |

Simplification of #31703

Commits
-------

75179d3 [Form] do not iterate twice on the extended types
@Tobion Tobion deleted the simplify-form-code branch June 1, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto approved these changes

@vudaltsov vudaltsov vudaltsov approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Tobion @nicolas-grekas @yceruto @vudaltsov @carsonbot