[Security][Http] Remove BC layers #31782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Jun 1, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
c6ed734 to
6e36e03
Compare
chalasr
pushed a commit
that referenced
this pull request
Jun 1, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Security][Guard] Forbid security-http >= 5.0 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Unlocks #31782. To be discarded on master Commits ------- e2c9701 [Security][Guard] Forbid security-http >= 5.0
|
Green |
OskarStark
reviewed
Jun 1, 2019
6e36e03 to
0fb3f8f
Compare
6d49d7f to
b9eb4d4
Compare
chalasr
commented
Jun 3, 2019
| @@ -39,7 +39,7 @@ | |||
| * | |||
| * @author Fabien Potencier <fabien@symfony.com> | |||
| * | |||
| * @final since Symfony 4.3, EventDispatcherInterface type-hints will be updated to the interface from symfony/contracts in 5.0 | |||
There was a problem hiding this comment.
Type hints unchanged because the class calls methods specific to the component interface (addListener)
b9eb4d4 to
f89c0e5
Compare
fabpot
requested changes
Jun 4, 2019
f89c0e5 to
81e9974
Compare
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 4, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Security][Http] Remove BC layers | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 81e9974 [Security][Http] Remove BC layers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.