Skip to content

[Validator] Standardizing validation messages #31788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Validator] Standardizing validation messages #31788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e65413e
Avoid addressing the client
Jun 1, 2019
78e308a
Conform to the same format as all validation messages
Jun 1, 2019
08557ba
Fix imprecise translation
Jun 1, 2019
7818fcf
Fix pluralized messages
Jun 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Validator/Constraints/CardScheme.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class CardScheme extends Constraint
self::INVALID_FORMAT_ERROR => 'INVALID_FORMAT_ERROR',
];

public $message = 'Unsupported card type or invalid card number.';
public $message = 'This is an unsupported card type or invalid card number.';
public $schemes;

public function getDefaultOption()
Expand Down
6 changes: 3 additions & 3 deletions src/Symfony/Component/Validator/Constraints/Choice.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ class Choice extends Constraint
public $strict = false;
public $min;
public $max;
public $message = 'The value you selected is not a valid choice.';
public $message = 'The selected value is not a valid choice.';
public $multipleMessage = 'One or more of the given values is invalid.';
public $minMessage = 'You must select at least {{ limit }} choice.|You must select at least {{ limit }} choices.';
public $maxMessage = 'You must select at most {{ limit }} choice.|You must select at most {{ limit }} choices.';
public $minMessage = 'At least {{ limit }} choice must be selected.|At least {{ limit }} choices must be selected.';
public $maxMessage = 'At most {{ limit }} choice must be selected.|At most {{ limit }} choices must be selected.';

/**
* {@inheritdoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Validator/Constraints/Luhn.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@ class Luhn extends Constraint
self::CHECKSUM_FAILED_ERROR => 'CHECKSUM_FAILED_ERROR',
];

public $message = 'Invalid card number.';
public $message = 'This is an invalid card number.';
}
10 changes: 5 additions & 5 deletions src/Symfony/Component/Validator/Resources/translations/validators.af.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@
<target>Hierdie waarde moet leeg wees.</target>
</trans-unit>
<trans-unit id="5">
<source>The value you selected is not a valid choice.</source>
<source>The selected value is not a valid choice.</source>
<target>Die waarde wat jy gekies het is nie 'n geldige keuse nie.</target>
</trans-unit>
<trans-unit id="6">
<source>You must select at least {{ limit }} choice.|You must select at least {{ limit }} choices.</source>
<source>At least {{ limit }} choice must be selected.|At least {{ limit }} choices must be selected.</source>
<target>Jy moet ten minste {{ limit }} kies.|Jy moet ten minste {{ limit }} keuses kies.</target>
</trans-unit>
<trans-unit id="7">
<source>You must select at most {{ limit }} choice.|You must select at most {{ limit }} choices.</source>
<source>At most {{ limit }} choice must be selected.|At most {{ limit }} choices must be selected.</source>
<target>Jy moet by die meeste {{ limit }} keuse kies.|Jy moet by die meeste {{ limit }} keuses kies.</target>
</trans-unit>
<trans-unit id="8">
Expand Down Expand Up @@ -215,11 +215,11 @@
<target>Hierdie versameling moet presies {{ limit }} element bevat.|Hierdie versameling moet presies {{ limit }} elemente bevat.</target>
</trans-unit>
<trans-unit id="57">
<source>Invalid card number.</source>
<source>This is an invalid card number.</source>
<target>Ongeldige kredietkaart nommer.</target>
</trans-unit>
<trans-unit id="58">
<source>Unsupported card type or invalid card number.</source>
<source>This is an unsupported card type or invalid card number.</source>
<target>Nie-ondersteunde tipe kaart of ongeldige kredietkaart nommer.</target>
</trans-unit>
<trans-unit id="59">
Expand Down
10 changes: 5 additions & 5 deletions src/Symfony/Component/Validator/Resources/translations/validators.ar.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@
<target>هذه القيمة يجب ان تكون فارغة.</target>
</trans-unit>
<trans-unit id="5">
<source>The value you selected is not a valid choice.</source>
<source>The selected value is not a valid choice.</source>
<target>القيمة المختارة ليست خيارا صحيحا.</target>
</trans-unit>
<trans-unit id="6">
<source>You must select at least {{ limit }} choice.|You must select at least {{ limit }} choices.</source>
<source>At least {{ limit }} choice must be selected.|At least {{ limit }} choices must be selected.</source>
<target>يجب ان تختار {{ limit }} اختيار على الاقل.|يجب ان تختار {{ limit }} اختيار على الاقل.|يجب ان تختار {{ limit }} اختيارات على الاقل.|يجب ان تختار {{ limit }} اختيار على الاقل.|يجب ان تختار {{ limit }} اختيار على الاقل.|يجب ان تختار {{ limit }} اختيار على الاقل.</target>
</trans-unit>
<trans-unit id="7">
<source>You must select at most {{ limit }} choice.|You must select at most {{ limit }} choices.</source>
<source>At most {{ limit }} choice must be selected.|At most {{ limit }} choices must be selected.</source>
<target>يجب ان تختار {{ limit }} اختيار على الاكثر.|يجب ان تختار {{ limit }} اختيار على الاكثر.|يجب ان تختار {{ limit }} اختيارات على الاكثر.|يجب ان تختار {{ limit }} اختيار على الاكثر.|يجب ان تختار {{ limit }} اختيار على الاكثر.|يجب ان تختار {{ limit }} اختيار على الاكثر.</target>
</trans-unit>
<trans-unit id="8">
Expand Down Expand Up @@ -215,11 +215,11 @@
<target>هذه المجموعة يجب ان تحتوى على {{ limit }} عنصر فقط.|هذه المجموعة يجب ان تحتوى على {{ limit }} عنصر فقط.|هذه المجموعة يجب ان تحتوى على {{ limit }} عناصر فقط.|هذه المجموعة يجب ان تحتوى على {{ limit }} عنصر فقط.|هذه المجموعة يجب ان تحتوى على {{ limit }} عنصر فقط.|هذه المجموعة يجب ان تحتوى على {{ limit }} عنصر فقط.</target>
</trans-unit>
<trans-unit id="57">
<source>Invalid card number.</source>
<source>This is an invalid card number.</source>
<target>رقم البطاقه غير صحيح.</target>
</trans-unit>
<trans-unit id="58">
<source>Unsupported card type or invalid card number.</source>
<source>This is an unsupported card type or invalid card number.</source>
<target>نوع البطاقه غير مدعوم او الرقم غير صحيح.</target>
</trans-unit>
<trans-unit id="59">
Expand Down
10 changes: 5 additions & 5 deletions src/Symfony/Component/Validator/Resources/translations/validators.az.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@
<target>Bu dəyər boş olmalıdır.</target>
</trans-unit>
<trans-unit id="5">
<source>The value you selected is not a valid choice.</source>
<source>The selected value is not a valid choice.</source>
<target>Seçdiyiniz dəyər düzgün bir seçim değil.</target>
</trans-unit>
<trans-unit id="6">
<source>You must select at least {{ limit }} choice.|You must select at least {{ limit }} choices.</source>
<source>At least {{ limit }} choice must be selected.|At least {{ limit }} choices must be selected.</source>
<target>Ən az {{ limit }} seçim qeyd edilməlidir.</target>
</trans-unit>
<trans-unit id="7">
<source>You must select at most {{ limit }} choice.|You must select at most {{ limit }} choices.</source>
<source>At most {{ limit }} choice must be selected.|At most {{ limit }} choices must be selected.</source>
<target>Ən çox {{ limit }} seçim qeyd edilməlidir.</target>
</trans-unit>
<trans-unit id="8">
Expand Down Expand Up @@ -215,11 +215,11 @@
<target>Bu kolleksiyada tam olaraq {{ limit }} element olmalıdır.</target>
</trans-unit>
<trans-unit id="57">
<source>Invalid card number.</source>
<source>This is an invalid card number.</source>
<target>Yanlış kart nömrəsi.</target>
</trans-unit>
<trans-unit id="58">
<source>Unsupported card type or invalid card number.</source>
<source>This is an unsupported card type or invalid card number.</source>
<target>Dəstəklənməyən kart tipi və ya yanlış kart nömrəsi.</target>
</trans-unit>
</body>
Expand Down
12 changes: 6 additions & 6 deletions src/Symfony/Component/Validator/Resources/translations/validators.be.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@
<target>Значэнне павінна быць пустым.</target>
</trans-unit>
<trans-unit id="5">
<source>The value you selected is not a valid choice.</source>
<source>The selected value is not a valid choice.</source>
<target>Абранае вамі значэнне не сапраўднае.</target>
</trans-unit>
<trans-unit id="6">
<source>You must select at least {{ limit }} choice.|You must select at least {{ limit }} choices.</source>
<source>At least {{ limit }} choice must be selected.|At least {{ limit }} choices must be selected.</source>
<target>Вы павінны выбраць хаця б {{ limit }} варыянт.|Вы павінны выбраць хаця б {{ limit }} варыянтаў.</target>
</trans-unit>
<trans-unit id="7">
<source>You must select at most {{ limit }} choice.|You must select at most {{ limit }} choices.</source>
<source>At most {{ limit }} choice must be selected.|At most {{ limit }} choices must be selected.</source>
<target>Вы павінны выбраць не больш за {{ limit }} варыянт.|Вы павінны выбраць не больш за {{ limit }} варыянтаў.</target>
</trans-unit>
<trans-unit id="8">
Expand Down Expand Up @@ -215,11 +215,11 @@
<target>Калекцыя павінна змяшчаць роўна {{ limit }} элемент.|Калекцыя павінна змяшчаць роўна {{ limit }} элементаў.</target>
</trans-unit>
<trans-unit id="57">
<source>Invalid card number.</source>
<source>This is an invalid card number.</source>
<target>Несапраўдны нумар карты.</target>
</trans-unit>
<trans-unit id="58">
<source>Unsupported card type or invalid card number.</source>
<source>This is an unsupported card type or invalid card number.</source>
<target>Тып карты не падтрымліваецца або несапраўдны нумар карты.</target>
</trans-unit>
<trans-unit id="59">
Expand Down Expand Up @@ -359,7 +359,7 @@
<target>Значэнне не з'яўляецца сапраўдным гадзінным поясам.</target>
</trans-unit>
<trans-unit id="93">
<source>This password has been leaked in a data breach, it must not be used. Please use another password.</source>
<source>This password has been leaked in a data breach. A different password must be used.</source>
<target>Гэты пароль быў выкрадзены ў выніку ўзлому дадзеных, таму яго нельга выкарыстоўваць. Калі ласка, выкарыстоўвайце іншы пароль.</target>
</trans-unit>
</body>
Expand Down
10 changes: 5 additions & 5 deletions src/Symfony/Component/Validator/Resources/translations/validators.bg.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@
<target>Стойността трябва да бъде празна.</target>
</trans-unit>
<trans-unit id="5">
<source>The value you selected is not a valid choice.</source>
<source>The selected value is not a valid choice.</source>
<target>Избраната стойност е невалидна.</target>
</trans-unit>
<trans-unit id="6">
<source>You must select at least {{ limit }} choice.|You must select at least {{ limit }} choices.</source>
<source>At least {{ limit }} choice must be selected.|At least {{ limit }} choices must be selected.</source>
<target>Трябва да изберете поне {{ limit }} опция.|Трябва да изберете поне {{ limit }} опции.</target>
</trans-unit>
<trans-unit id="7">
<source>You must select at most {{ limit }} choice.|You must select at most {{ limit }} choices.</source>
<source>At most {{ limit }} choice must be selected.|At most {{ limit }} choices must be selected.</source>
<target>Трябва да изберете най-много {{ limit }} опция.|Трябва да изберете най-много {{ limit }} опции.</target>
</trans-unit>
<trans-unit id="8">
Expand Down Expand Up @@ -215,11 +215,11 @@
<target>Колекцията трябва да съдържа точно {{ limit }} елемент.|Колекцията трябва да съдържа точно {{ limit }} елемента.</target>
</trans-unit>
<trans-unit id="57">
<source>Invalid card number.</source>
<source>This is an invalid card number.</source>
<target>Невалиден номер на карта.</target>
</trans-unit>
<trans-unit id="58">
<source>Unsupported card type or invalid card number.</source>
<source>This is an unsupported card type or invalid card number.</source>
<target>Неподдържан тип карта или невалиден номер на карта.</target>
</trans-unit>
<trans-unit id="59">
Expand Down
10 changes: 5 additions & 5 deletions src/Symfony/Component/Validator/Resources/translations/validators.ca.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@
<target>Aquest valor hauria d'estar buit.</target>
</trans-unit>
<trans-unit id="5">
<source>The value you selected is not a valid choice.</source>
<source>The selected value is not a valid choice.</source>
<target>El valor seleccionat no és una opció vàlida.</target>
</trans-unit>
<trans-unit id="6">
<source>You must select at least {{ limit }} choice.|You must select at least {{ limit }} choices.</source>
<source>At least {{ limit }} choice must be selected.|At least {{ limit }} choices must be selected.</source>
<target>Ha de seleccionar almenys {{ limit }} opció.|Ha de seleccionar almenys {{ limit }} opcions.</target>
</trans-unit>
<trans-unit id="7">
<source>You must select at most {{ limit }} choice.|You must select at most {{ limit }} choices.</source>
<source>At most {{ limit }} choice must be selected.|At most {{ limit }} choices must be selected.</source>
<target>Ha de seleccionar com a màxim {{ limit }} opció.|Ha de seleccionar com a màxim {{ limit }} opcions.</target>
</trans-unit>
<trans-unit id="8">
Expand Down Expand Up @@ -215,11 +215,11 @@
<target>Aquesta col·lecció ha de contenir exactament {{ limit }} element.|Aquesta col·lecció ha de contenir exactament {{ limit }} elements.</target>
</trans-unit>
<trans-unit id="57">
<source>Invalid card number.</source>
<source>This is an invalid card number.</source>
<target>Número de targeta invàlid.</target>
</trans-unit>
<trans-unit id="58">
<source>Unsupported card type or invalid card number.</source>
<source>This is an unsupported card type or invalid card number.</source>
<target>Tipus de targeta no suportada o número de targeta invàlid.</target>
</trans-unit>
<trans-unit id="59">
Expand Down
10 changes: 5 additions & 5 deletions src/Symfony/Component/Validator/Resources/translations/validators.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@
<target>Tato hodnota musí být prázdná.</target>
</trans-unit>
<trans-unit id="5">
<source>The value you selected is not a valid choice.</source>
<source>The selected value is not a valid choice.</source>
<target>Vybraná hodnota není platnou možností.</target>
</trans-unit>
<trans-unit id="6">
<source>You must select at least {{ limit }} choice.|You must select at least {{ limit }} choices.</source>
<source>At least {{ limit }} choice must be selected.|At least {{ limit }} choices must be selected.</source>
<target>Musí být vybrána nejméně {{ limit }} možnost.|Musí být vybrány nejméně {{ limit }} možnosti.|Musí být vybráno nejméně {{ limit }} možností.</target>
</trans-unit>
<trans-unit id="7">
<source>You must select at most {{ limit }} choice.|You must select at most {{ limit }} choices.</source>
<source>At most {{ limit }} choice must be selected.|At most {{ limit }} choices must be selected.</source>
<target>Musí být vybrána maximálně {{ limit }} možnost.|Musí být vybrány maximálně {{ limit }} možnosti.|Musí být vybráno maximálně {{ limit }} možností.</target>
</trans-unit>
<trans-unit id="8">
Expand Down Expand Up @@ -215,11 +215,11 @@
<target>Tato kolekce musí obsahovat přesně {{ limit }} prvek.|Tato kolekce musí obsahovat přesně {{ limit }} prvky.|Tato kolekce musí obsahovat přesně {{ limit }} prvků.</target>
</trans-unit>
<trans-unit id="57">
<source>Invalid card number.</source>
<source>This is an invalid card number.</source>
<target>Neplatné číslo karty.</target>
</trans-unit>
<trans-unit id="58">
<source>Unsupported card type or invalid card number.</source>
<source>This is an unsupported card type or invalid card number.</source>
<target>Nepodporovaný typ karty nebo neplatné číslo karty.</target>
</trans-unit>
<trans-unit id="59">
Expand Down
Loading