[Lock] prune PdoStorage table on each save according to gcProbability #31804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about moving the "if" in a "finally" block? (an not put it inside the method I agree) |
|
Closing in favor of #32076, thank you! |
|
Okay perfect. Sorry I haven't had time to work on this, but #32076 looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expected the
\Symfony\Component\Lock\Store\PdoStore::prunemethod to be called according togcProbabilityevery time I interact with a lock. But\Symfony\Component\Lock\Store\PdoStore::savereturns early on success. As I see it, this means that expired locks are pruned much less often than specified bygcProbability.This PR fixes that by calling prune before the early return.
I'm not so sure if checking the probability inside the
prunemethod is a good solution. Maybe it would be nicer to have a separate function (randomPrune).