Skip to content

[DoctrineBridge] don't add embedded properties to wrapping class metadata #31811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2019
Merged

[DoctrineBridge] don't add embedded properties to wrapping class metadata #31811

merged 1 commit into from
Jun 4, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 3, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31775
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.3 milestone Jun 3, 2019
@xabbuh xabbuh mentioned this pull request Jun 3, 2019
Closed
dunglas
dunglas approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @xabbuh! You're too fast for me :)

Korbeil
Korbeil approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks ! 😃

@xabbuh xabbuh changed the title [DoctrineBridge] don't wrapper embedded properties to wrapping class [DoctrineBridge] don't add embedded properties to wrapping class metadata Jun 3, 2019
@fabpot
Copy link
Member

fabpot commented Jun 4, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 56fe025 into symfony:4.3 Jun 4, 2019
fabpot added a commit that referenced this pull request Jun 4, 2019
@fabpot
bug #31811 [DoctrineBridge] don't add embedded properties to wrapping…
66b87ab 
… class metadata (xabbuh)

This PR was merged into the 4.3 branch.

Discussion
----------

[DoctrineBridge] don't add embedded properties to wrapping class metadata

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31775
| License       | MIT
| Doc PR        |

Commits
-------

56fe025 don't add embedded properties to wrapping class metadata
@xabbuh xabbuh deleted the issue-31775 branch June 4, 2019 06:21
@fabpot fabpot mentioned this pull request Jun 6, 2019
Merged
@martiis martiis mentioned this pull request Jun 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas dunglas approved these changes

@Korbeil Korbeil Korbeil approved these changes

@phansys phansys phansys approved these changes

Assignees
No one assigned
Labels
Bug DoctrineBridge Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@xabbuh @fabpot @dunglas @Korbeil @phansys @carsonbot