fix type hint for salt in PasswordEncoderInterface #31813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Jun 3, 2019
|
The |
xabbuh
approved these changes
Jun 3, 2019
Tobion
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
Null is also used
But in general I think we should deprecate the salt argument completely as it's not best practice anymore. E.g. php also deprecated it in https://www.php.net/manual/en/function.password-hash.php
100% the only issue is figuring out a smooth way to upgrade. I think we'll be able to do it in 5.1 once we provide a way to migrate passwords to new hash algos. Would that make sense? |
1f0ea28 to
0e741f9
Compare
|
Thank you @garak. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 3, 2019
This PR was squashed before being merged into the 3.4 branch (closes #31813). Discussion ---------- fix type hint for salt in PasswordEncoderInterface See issue #31812 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31812 | License | MIT | Doc PR | none Pretty self-explanatory Commits ------- 0e741f9 fix type hint for salt in PasswordEncoderInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #31812
Pretty self-explanatory