[Mailer] Set default crypto method #31846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 4, 2019
src/Symfony/Component/Mailer/Transport/Smtp/Stream/SocketStream.php
Outdated
Show resolved
Hide resolved
|
@bpolaszek Looks like an unrelated commit is part of your PR now (from a PR I've just merged). |
|
@fabpot Yes, since travis and appveyor failed on my 2nd commit, I tried to rebase and it looks like it's all messed up... I'm trying again. |
|
Well, builds are still failing but I don't think it's related. |
fabpot
approved these changes
Jun 5, 2019
|
Thank you @bpolaszek. |
fabpot
added a commit
that referenced
this pull request
Jun 5, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Mailer] Set default crypto method | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31105 | License | MIT | Doc PR | - This PR fixes #31105 by providing `STREAM_CRYPTO_METHOD_TLS_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT` as default crypto method when none is defined in user options and TLS is enabled. Commits ------- 4f0ad25 Set default crypto method - Fix #31105
Merged
|
Works now like a charm using Amazon SES transport — which relays on (e)smtp transport. Thank you @bpolaszek ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #31105 by providing
STREAM_CRYPTO_METHOD_TLS_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_1_CLIENTas default crypto method when none is defined in user options and TLS is enabled.