[Form] Fix wrong DateTime on outdated ICU library #31865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ro0NL |
|
@aweelex Does it work if we pass the timezone as a |
|
@xabbuh oh, yes. And it seems to be the best way to solve this problem. Because we already have exeption on wrong |
|
Thank you for checking. Can you rebase your changes on the |
|
Ok, it seems that changes should go to 3.4 and 4.4. I rebased commits to 3.4. Is everything alright here? @nicolas-grekas? |
xabbuh
approved these changes
Jun 6, 2019
ro0NL
approved these changes
Jun 6, 2019
fabpot
approved these changes
Jun 6, 2019
|
Thank you @aweelex. |
fabpot
added a commit
that referenced
this pull request
Jun 6, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Form] Fix wrong DateTime on outdated ICU library | Q | A | | --- | --- | | Branch? | 3.4 | | Bug fix? | Yes | | New feature? | No | | BC breaks? | No | | Deprecations? | No | | Tests pass? | Yes | | Fixed tickets | --- | | License | MIT | There is a problem, when server uses outdated version of ICU (php-intl). It throws no exeption or debug message on unexisting Timezone. So sometimes you can get wrong DateTime in Forms, because Intl uses 'Etc/Unknown' (UTC+0) instead correct Timezone. And it happens very unobvious. I added `\IntlExeption` for that cases. Commits ------- a6025ab Change IntlTimeZone to DateTimeZone
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem, when server uses outdated version of ICU (php-intl).
It throws no exeption or debug message on unexisting Timezone. So sometimes you can get wrong DateTime in Forms, because Intl uses 'Etc/Unknown' (UTC+0) instead correct Timezone. And it happens very unobvious.
I added
\IntlExeptionfor that cases.