[WebProfilerBundle] Add clear button to ajax tab #31876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1eb707 to
b3a5dab
Compare
e424848 to
945955a
Compare
945955a to
0c75396
Compare
|
@Matts Could you please post a screenshot on how it look ? |
|
Option 1 (current) Option 2 (i find this ugly, and not in line with the rest of the tabs) |
ro0NL
reviewed
Jun 8, 2019
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/ajax.html.twig
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/ajax.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
Outdated
Show resolved
Hide resolved
|
It seems it does not clear the calls's list just the counter, except if this is wanted? Also for my last reset (post error), the block is still in "error" mode (red display)
|
I indeed forgot to clear the request list. See changes |
54919ec to
da45743
Compare
dFayet
reviewed
Jun 24, 2019
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
Outdated
Show resolved
Hide resolved
dFayet
approved these changes
Jun 24, 2019
d5c275a to
5716a70
Compare
|
Status: ready |
fabpot
approved these changes
Jul 8, 2019
5716a70 to
6bff4db
Compare
|
Thank you @Matts. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
This PR was squashed before being merged into the 4.4 branch (closes #31876). Discussion ---------- [WebProfilerBundle] Add clear button to ajax tab | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31839 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> For pages that have been open for a long time, the profiler ajax tab can start filling up fast. In #31839 the request to allow the history to be cleared with one click. The reason why I did not align the button to the right, is because after looking at the other tabs. None of them had items that were aligned to the right. Moved the addEventListener above the ajax tab logic to keep the code consistent. Ps. Please be nice, this is my first contribution 🍰 <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- 6bff4db [WebProfilerBundle] Add clear button to ajax tab
|
Congrats for your first contrib @Matts! |
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pages that have been open for a long time, the profiler ajax tab can start filling up fast. In #31839 the request to allow the history to be cleared with one click.
The reason why I did not align the button to the right, is because after looking at the other tabs. None of them had items that were aligned to the right. Moved the addEventListener above the ajax tab logic to keep the code consistent.
Ps. Please be nice, this is my first contribution 🍰