Skip to content

[HttpKernel] deprecate the usage of the deprecated events to ease deleting them #31886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Simperfit
Copy link
Contributor

@Simperfit Simperfit commented Jun 5, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets none
License MIT
Doc PR

This is needed to fix the tests in #31672, since all the class has been made final since 4.3, we don't have any problem changing the type hint in 4.4 and then using the right type hint in 5.0.

@Simperfit Simperfit force-pushed the deprecation/deprecate-the-event-to-ease-the-deletion-of-them branch from e1153f0 to fde6c62 Compare June 5, 2019 18:34
@nicolas-grekas
Copy link
Member

That's a BC break, not possible.

@nicolas-grekas nicolas-grekas added this to the next milestone Jun 6, 2019
@Simperfit Simperfit deleted the deprecation/deprecate-the-event-to-ease-the-deletion-of-them branch June 7, 2019 17:56
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants