Several components are incompatible with HttpKernel 5.0 #31890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cd5c0e to
8c73b90
Compare
| @@ -18,7 +18,7 @@ | |||
| "require": { | |||
| "php": "^7.1.3", | |||
| "symfony/config": "^4.2|^5.0", | |||
| "symfony/http-kernel": "^4.3|^5.0", | |||
| "symfony/http-kernel": "^4.3", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Would other projects be affected in the same way ? This would tell me that we miss a migration path here.
There was a problem hiding this comment.
The issue exists only if listener methods are extensibility point by inheritance. That's not the case most of the time, and even if it is, there are ways around.
There was a problem hiding this comment.
great that we marked our listeners as @final to avoid similar issues in the future...
| @@ -20,7 +20,7 @@ | |||
| "ext-xml": "*", | |||
| "symfony/config": "^4.2|^5.0", | |||
| "symfony/dependency-injection": "^4.2|^5.0", | |||
| "symfony/http-kernel": "^4.3|^5.0", | |||
| "symfony/http-kernel": "^4.3", | |||
There was a problem hiding this comment.
| @@ -19,7 +19,7 @@ | |||
| "php": "^7.1.3", | |||
| "symfony/security-core": "^4.3", | |||
| "symfony/http-foundation": "^3.4|^4.0|^5.0", | |||
| "symfony/http-kernel": "^4.3|^5.0", | |||
| "symfony/http-kernel": "^4.3", | |||
There was a problem hiding this comment.
8c73b90 to
321a416
Compare
321a416 to
a0e4ad3
Compare
nicolas-grekas
approved these changes
Jun 6, 2019
|
Thank you @Simperfit. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 6, 2019
…(Simperfit) This PR was merged into the 4.4 branch. Discussion ---------- Several components are incompatible with HttpKernel 5.0 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | none <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> This will help to finish the HttpKernel dead code removal (#31672) as this conflict with the component since the type-hint of several listener has been updated. Commits ------- a0e4ad3 Several components are incompatible with HttpKernel 5.0
Tobion
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help to finish the HttpKernel dead code removal (#31672) as this conflict with the component since the type-hint of several listener has been updated.