Skip to content

PropertyInfoLoader should not try to add validation to non-existent property #31936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2019
Merged

PropertyInfoLoader should not try to add validation to non-existent property #31936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Mapping/Loader/PropertyInfoLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ public function loadClassMetadata(ClassMetadata $metadata)
continue;
}

if (!property_exists($className, $property)) {
continue;
}

$types = $this->typeExtractor->getTypes($className, $property);
if (null === $types) {
continue;
Expand Down
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Tests/Fixtures/PropertyInfoLoaderEntity.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,8 @@ class PropertyInfoLoaderEntity
public $alreadyPartiallyMappedCollection;

public $readOnly;

public function setNonExistentField()
{
}
}
1 change: 1 addition & 0 deletions src/Symfony/Component/Validator/Tests/Mapping/Loader/PropertyInfoLoaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ public function testLoadClassMetadata()
'alreadyMappedNotBlank',
'alreadyPartiallyMappedCollection',
'readOnly',
'nonExistentField',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No asserts were added, but, without the fix, these changes are enough to trigger an exception to be thrown while running this test.

])
;
$propertyInfoStub
Expand Down