[DomCrawler][Feature][DX] Add Form::getName() method #31959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea ! |
Simperfit
suggested changes
Jun 9, 2019
Simperfit
approved these changes
Jun 13, 2019
fabpot
requested changes
Jun 13, 2019
fabpot
approved these changes
Jun 14, 2019
8095c37 to
ff53cb4
Compare
|
Thank you @JustBlackBird. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2019
…JustBlackBird) This PR was squashed before being merged into the 4.4 branch (closes #31959). Discussion ---------- [DomCrawler][Feature][DX] Add Form::getName() method | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | None | License | MIT | Doc PR | symfony/symfony-docs#11705 The PR adds `Symfony\Component\DomCrawler\Form::getName` method. The method is actually a syntax sugar but can improve DX when dealing with tests. For example, in the snippet ```php $client = static::createClient(); $crawler = $client->request('GET', '/post/hello-world'); $form = $crawler->selectButton('submit')->form(); $form['my_form[name]'] = 'Fabien'; $form['my_form[subject]'] = 'Symfony rocks!'; ``` the prefix in field name (`my_form`) is form name, which is generated by Symfony automatically. The method, added in the PR helps to get that name in a most obvious way. Commits ------- ff53cb4 [DomCrawler][Feature][DX] Add Form::getName() method
|
You're welcome @fabpot 😄 |
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds
Symfony\Component\DomCrawler\Form::getNamemethod.The method is actually a syntax sugar but can improve DX when dealing with tests. For example, in the snippet
the prefix in field name (
my_form) is form name, which is generated by Symfony automatically. The method, added in the PR helps to get that name in a most obvious way.