[Messenger] Doctrine Connection find and findAll now correctly decode headers #31966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroze
reviewed
Jun 9, 2019
src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php
Outdated
Show resolved
Hide resolved
TimoBakx
commented
Jun 9, 2019
fabpot
approved these changes
Jun 26, 2019
|
Thank you @TimoBakx. |
fabpot
added a commit
that referenced
this pull request
Jun 26, 2019
…ctly decode headers (TimoBakx) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Doctrine Connection find and findAll now correctly decode headers | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31916 | License | MIT | Doc PR | N/A The Doctrine transport `Connection` class methods `find` and `findAll` did not JSON-decode the headers of the envelope after retrieving it from Doctrine. The `get` method, however, did this correctly. I added two tests to verify the results of `find` and `findAll` and then added the JSON-decoding to the `Connection` class. I moved the JSON-decoding to a separate method to avoid duplicate code. Commits ------- 3aec2ac [Messenger] Doctrine Connection find and findAll now correctly decode headers
|
Thanks for merging my first ever PR to the Symfony code. And thank you @sroze for your review. |
|
Congrats on your first PR! I did not realize it was your first. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Doctrine transport
Connectionclass methodsfindandfindAlldid not JSON-decode the headers of the envelope after retrieving it from Doctrine. Thegetmethod, however, did this correctly.I added two tests to verify the results of
findandfindAlland then added the JSON-decoding to theConnectionclass. I moved the JSON-decoding to a separate method to avoid duplicate code.