Skip to content

[DI] remove deprecated tag !tagged in favor of !tagged_iterator #31967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2019
Merged

[DI] remove deprecated tag !tagged in favor of !tagged_iterator #31967

merged 1 commit into from
Jun 9, 2019

Conversation

jschaedl
Copy link
Contributor

@jschaedl jschaedl commented Jun 9, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets related ticket #31289
License MIT
Doc PR symfony/symfony-docs#tbd

This PR removes tag tagged which was deprecated in #31321

@jschaedl jschaedl changed the title [DI] removed tagged [DI] remove deprecated tag !tagged in favor of !tagged_iterator Jun 9, 2019
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jun 9, 2019
@nicolas-grekas
Copy link
Member

Thank you @jschaedl.

@nicolas-grekas nicolas-grekas merged commit 9978184 into symfony:master Jun 9, 2019
nicolas-grekas added a commit that referenced this pull request Jun 9, 2019
@nicolas-grekas
minor #31967 [DI] remove deprecated tag !tagged in favor of !tagged_i…
e8c2a1b 
…terator (jschaedl)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[DI] remove deprecated tag !tagged in favor of !tagged_iterator

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | yes     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | related ticket #31289   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#tbd <!-- required for new features -->

This PR removes tag `tagged` which was deprecated in #31321

Commits
-------

9978184 [DI] removed tagged
@jschaedl jschaedl deleted the di-remove-tagged branch February 23, 2020 08:01
@X-Coder264 X-Coder264 mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC Break DependencyInjection Status: Needs Review
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jschaedl @nicolas-grekas @carsonbot