[HttpClient] add HttplugClient for compat with libs that need httplug v1 or v2 #31976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 10, 2019
src/Symfony/Component/HttpClient/Internal/HttplugClientTrait.php
Outdated
Show resolved
Hide resolved
31dd764 to
f223518
Compare
|
Rebased on top of #31980, waiting for it to be merged before this one. |
bbe103b to
27b138c
Compare
|
(rebased) |
stof
approved these changes
Jun 11, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Jun 11, 2019
…at need httplug v1 or v2 (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] add HttplugClient for compat with libs that need httplug v1 or v2 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Many libs still depend on httplug: https://packagist.org/packages/php-http/client-implementation/dependents Until they're all updated to PSR-18 or SFContracts, this PR provides an adapter for injecting a Symfony HttpClient into httplug-compatible classes, v1 or v2. Commits ------- 28674b1 [HttpClient] add HttplugClient for compat with libs that need httplug v1 or v2
|
I used this PR to merge itself, worked like a charm :) |
|
Is there a reason why it doesn't implement the |
|
No specific reasons, PR welcome as usual. |
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many libs still depend on httplug:
https://packagist.org/packages/php-http/client-implementation/dependents
Until they're all updated to PSR-18 or SFContracts, this PR provides an adapter for injecting a Symfony HttpClient into httplug-compatible classes, v1 or v2.