Skip to content

[HttpKernel] Remove TestEventDispatcher #31994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

derrabus
Copy link
Member

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

This class seems to be an orphaned test fixture. Let's delete it.

@derrabus
Copy link
Member Author

@fabbot-io seems to hang. But anyway, I wouldn't expect code style violations in this PR. 😇

@chalasr chalasr added this to the 5.0 milestone Jun 11, 2019
@fabpot
Copy link
Member

fabpot commented Jun 11, 2019

Thank you @derrabus.

@fabpot fabpot merged commit 48be09f into symfony:3.4 Jun 11, 2019
fabpot added a commit that referenced this pull request Jun 11, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[HttpKernel] Remove TestEventDispatcher

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

This class seems to be an orphaned test fixture. Let's delete it.

Commits
-------

48be09f [HttpKernel] Remove TestEventDispatcher.
@derrabus derrabus deleted the bugfix/remove-test-event-dispatcher branch June 11, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants