[Serializer] Handle true and false appropriately in CSV encoder #32007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
requested changes
Jun 12, 2019
b3ce057 to
25f8411
Compare
dunglas
approved these changes
Jun 13, 2019
25f8411 to
805dd49
Compare
Simperfit
approved these changes
Jun 13, 2019
kevin-verschaeve
approved these changes
Jun 13, 2019
fabpot
requested changes
Jun 13, 2019
ae229e4 to
58a7f46
Compare
fabpot
requested changes
Jun 14, 2019
fabpot
approved these changes
Jun 14, 2019
56c01b8 to
89cba00
Compare
|
Thank you @battye. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2019
…coder (battye) This PR was squashed before being merged into the 3.4 branch (closes #32007). Discussion ---------- [Serializer] Handle true and false appropriately in CSV encoder | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27642 | License | MIT | Doc PR | - Previously, if `true` was passed in as a value to the CSV encoder then `fputcsv()` would correctly treat it as 1. However, if `false` was passed in, it would be treated as a blank value. `null` would also be treated as a blank value. This fix makes it consistent so that true and false will map to 1 and 0, while null maps to an empty string. Commits ------- 89cba00 [Serializer] Handle true and false appropriately in CSV encoder
This was referenced Jun 26, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
truewas passed in as a value to the CSV encoder thenfputcsv()would correctly treat it as 1. However, iffalsewas passed in, it would be treated as a blank value.nullwould also be treated as a blank value.This fix makes it consistent so that true and false will map to 1 and 0, while null maps to an empty string.