Add BC layer for updated constructor types #32074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
that referenced
this pull request
Jun 17, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Add BC layer for updated constructor types | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Reverts some CS changes done in #32066 + replaces its BC breaks by a BC layer. Our CI is too good, it bites us hard when we break our own rules :) Commits ------- c34fcd9 Add BC layer for updated constructor types
Tobion
reviewed
Jun 17, 2019
| $name = ''; | ||
| } | ||
| if (false !== strpos($name, $pathSeparator)) { | ||
| if (false !== strpos($name = (string) $name, $pathSeparator)) { |
There was a problem hiding this comment.
Changing a variable, esp it's type within a call and later rely on this is really not-obivous. It took me a while to see this.
There was a problem hiding this comment.
I understand, but this reduces merge conflicts as you know.
|
I don't see why those changes were necessary. If tests in other branches fail, the tests should be fixed like I did in 4.4. This is purely a test setup problem like missing mocks that don't follow the contract. |
|
The CI is here to spot BC breaks, it did its job. We have bad past experiences about doing apparently minor changes but breaking real apps. Better stick to our processes. |
symfony-splitter
pushed a commit
to symfony/security-core
that referenced
this pull request
Jun 25, 2019
This PR was squashed before being merged into the 5.0-dev branch (closes #32160). Discussion ---------- Removed legacy code and cleanup | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - See symfony/symfony#32074, symfony/symfony#26981 labels: `HttpFoundation`, `Form`, `Security`, `SecurityBundle`, `Validator` Commits ------- 7b99fb45bb Removed legacy code and cleanup
fabpot
added a commit
that referenced
this pull request
Jun 25, 2019
This PR was squashed before being merged into the 5.0-dev branch (closes #32160). Discussion ---------- Removed legacy code and cleanup | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - See #32074, #26981 labels: `HttpFoundation`, `Form`, `Security`, `SecurityBundle`, `Validator` Commits ------- 7b99fb4 Removed legacy code and cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts some CS changes done in #32066 + replaces its BC breaks by a BC layer.
Our CI is too good, it bites us hard when we break our own rules :)