[FrameworkBundle] Use default_locale as default value for translator.fallbacks #32106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
approved these changes
Jun 19, 2019
fabpot
approved these changes
Jun 20, 2019
ogizanagi
approved these changes
Jun 21, 2019
xabbuh
reviewed
Jun 21, 2019
| ->beforeNormalization()->ifString()->then(function ($v) { return [$v]; })->end() | ||
| ->prototype('scalar')->end() | ||
| ->defaultValue(['en']) | ||
| ->defaultValue([]) |
There was a problem hiding this comment.
Not if default_local was set to the same value, right? Should always be the case?
There was a problem hiding this comment.
I don't think so. For a German site I would set default_locale to de but keep the fallback set to en if my team writes English messages and translations are provided later by a separate team.
There was a problem hiding this comment.
It's an edge case that can be fixed very easily, and deserves to be explicit IMHO. The current behavior create a WTF situation where you change the default_locale, but it's not taken into account by Symfony itself without having to change another setting.
nicolas-grekas
approved these changes
Jun 23, 2019
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Jul 5, 2019
…for translator.fallbacks (dunglas) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Use default_locale as default value for translator.fallbacks | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a Simplify translator's config: Before: ```yaml default_locale: fr translator: default_path: '%kernel.project_dir%/translations' fallbacks: - fr ``` After: ```yaml default_locale: fr translator: default_path: '%kernel.project_dir%/translations' ``` Commits ------- e0ef359 [FrameworkBundle] Use default_locale as default value for translator.fallbacks
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify translator's config:
Before:
After: