[Form] accept floats for input="string" in NumberType #32125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jun 20, 2019
•
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #31905, #32124 |
| License | MIT |
| Doc PR |
This was referenced Jun 20, 2019
yceruto
reviewed
Jun 20, 2019
src/Symfony/Component/Form/Extension/Core/DataTransformer/StringToFloatTransformer.php
Outdated
Show resolved
Hide resolved
|
Shouldn't we trigger a deprecation here so users actually uses string instead of floats in their entities? |
|
I have updated the code a bit. The changes made for the This allows us to deprecate the behaviour with a better message in 4.4 as suggested in #32125 (comment) and we do not need to weaken the |
ogizanagi
reviewed
Jun 21, 2019
yceruto
approved these changes
Jun 21, 2019
fabpot
added a commit
that referenced
this pull request
Jun 22, 2019
…ype (xabbuh) This PR was merged into the 4.4 branch. Discussion ---------- [Form] deprecate int/float for string input in NumberType | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #32125 (comment) | License | MIT | Doc PR | Commits ------- d8c008a deprecate int/float for string input in NumberType
fabpot
approved these changes
Jun 22, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 22, 2019
…buh) This PR was merged into the 4.3 branch. Discussion ---------- [Form] accept floats for input="string" in NumberType | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31905, #32124 | License | MIT | Doc PR | Commits ------- 2abf855 accept floats for input="string" in NumberType
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.