[HttpFoundation] Add a way to anonymize IPs #32194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
commented
Jun 26, 2019
xabbuh
reviewed
Jun 28, 2019
stof
reviewed
Jul 17, 2019
3cee079 to
e2dc6c1
Compare
|
Ok I updated wording/docblock, added tests and support for IPv4-mapped IPv6s (which complicates things a little, if anyone sees a better way to do this feel free, as long as the tests pass..), and now remove the last 8 bytes (/64 equivalent) of IPv6s. For me it's ready to ship now but any feedback is appreciated. |
e2dc6c1 to
9e62330
Compare
nicolas-grekas
approved these changes
Nov 8, 2019
chalasr
approved these changes
Nov 8, 2019
fabpot
approved these changes
Nov 9, 2019
|
Thank you @Seldaek. |
fabpot
added a commit
that referenced
this pull request
Nov 9, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] Add a way to anonymize IPs | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> TODO This is helpful for GDPR compliance reasons, and it isn't much code saved but it's also good if you don't have to think about how to do it. Commits ------- 9e62330 [HttpFoundation] Add a way to anonymize IPs
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful for GDPR compliance reasons, and it isn't much code saved but it's also good if you don't have to think about how to do it.