[ErrorCatcher] Make IDEs and static analysis tools happy #32221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Jun 27, 2019
•
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
stof
reviewed
Jun 27, 2019
src/Symfony/Component/ErrorHandler/ErrorRenderer/ErrorRenderer.php
Outdated
Show resolved
Hide resolved
fabpot
commented
Jun 27, 2019
| @@ -62,7 +62,7 @@ public function render($exception, string $format = 'html'): string | |||
| throw new ErrorRendererNotFoundException(sprintf('No error renderer found for format "%s".', $format)); | |||
| } | |||
|
|
|||
| if (!$exception instanceof FlattenException) { | |||
| if ($exception instanceof \Exception) { | |||
There was a problem hiding this comment.
Also makes mere mortal like me reason about the code more easily as create() takes an \Exception instance.
7ccb30b to
640ede4
Compare
stof
reviewed
Jun 27, 2019
src/Symfony/Component/ErrorHandler/ErrorRenderer/ErrorRenderer.php
Outdated
Show resolved
Hide resolved
yceruto
reviewed
Jun 27, 2019
640ede4 to
49dd0d7
Compare
49dd0d7 to
f511bc5
Compare
fabpot
added a commit
that referenced
this pull request
Jun 27, 2019
…py (fabpot) This PR was squashed before being merged into the 4.4 branch (closes #32221). Discussion ---------- [ErrorCatcher] Make IDEs and static analysis tools happy | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- f511bc5 deprecated FlattenException::create() 7dd9dbf [ErrorHandler] made IDEs and static analysis tools happy
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.